This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Make clippy an optional dependency #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
clippy_optional
branch
from
dc40a97
to
486fa90
Compare
|
It would also be nice if this library compiled on stable (it's not too hard to port it to do so). |
NikVolf
added
F8-enhancement 🎊
|
thanx, will merge after aster/quasi update |
gavofyork
added
A3-inprogress ⏳
|
Hi @Manishearth we've just got our CLA sorted; it's at https://cla.ethcore.io/ we can accept the contribution once that's sorted. Thanks! |
|
[clabot:check] |
|
@ethcore It looks like @Manishearth just signed our Contributor License Agreement. 👍 Always at your service, clabot |
|
(will re-test this locally since quasi updated) |
Manishearth
force-pushed
the
clippy_optional
branch
2 times, most recently
from
deb5065
to
a5f91ee
Compare
|
Pushed changes. This should work. |
Manishearth
force-pushed
the
clippy_optional
branch
2 times, most recently
from
211d270
to
1355e87
Compare
Manishearth
force-pushed
the
clippy_optional
branch
from
1355e87
to
8802fb2
Compare
|
failed build? |
gavofyork
added
A5-grumble 🔥
|
I'm not certain why that's happening. It's working locally. I'll poke at it later. |
|
@Manishearth no worries, we'll integrate the patch on our own as part of transition to compiling with rustc beta |
arkpar
added
A3-inprogress ⏳
This was referenced Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be run locally with
cargo build --features dev, but there's no need to include it in the standard build.Untested, since aster/quasi haven't yet been updated for the current nightly. Will test when that happens.