Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Split Tab from TabBar #4318

Merged
merged 2 commits into from
Jan 27, 2017
Merged

Split Tab from TabBar #4318

merged 2 commits into from
Jan 27, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Jan 26, 2017 •
edited
Loading

  • single component per file (copy & paste of Tab from original)
  • testing for Tab rendering (instance methods)
  • smoketesting for TabBar

Split from https://github.com/ethcore/parity/pull/4178

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 26, 2017
@jacogr jacogr mentioned this pull request Jan 26, 2017
Merged
jacogr added a commit that referenced this pull request Jan 27, 2017
@jacogr
Merge #4318
c6fbeaa
@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 27, 2017
@jacogr jacogr merged commit b51b784 into master Jan 27, 2017
@jacogr jacogr deleted the jg-tabbar-tabs branch January 27, 2017 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacogr @ngotchac