Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

DeleteAccount & LoadContract modal updates #4320

Merged
merged 2 commits into from
Jan 27, 2017
Merged

DeleteAccount & LoadContract modal updates #4320

merged 2 commits into from
Jan 27, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Jan 27, 2017

Part of the ongoing journey to externalise strings and have tests in-place to confirm behaviour. For both modals -

  • convert to i18n strings
  • tests for interactions

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 27, 2017
@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 27, 2017
@jacogr jacogr merged commit 1940809 into master Jan 27, 2017
@jacogr jacogr deleted the jg-modals-i18n branch January 27, 2017 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants