Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

UDP Discovery #440

Merged
merged 55 commits into from
Feb 19, 2016
Merged

UDP Discovery #440

merged 55 commits into from
Feb 19, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Feb 15, 2016

In this PR:

  • Discovery over UPD
  • Node table backed by json file
  • Node key file
  • Public IP address detection

@arkpar
Discovery packets
09b6503
@arkpar
Merge branch 'master' of github.com:ethcore/parity into discovery
48924f4
@arkpar
Merge branch 'net' of github.com:ethcore/parity into discovery
2af379d
@arkpar
UDP discovery working
62b9f4b
@arkpar
Small refactoring
76ea030
@arkpar
Homestead block set to 1100000
9768fdd
@arkpar
Reduced thread contention
2d89708
@arkpar
Refactored host to use different containers for handshakes and sessions
718646f
@arkpar
Fixed panic on session creation
7503d66
@arkpar
Handle session creation error
dee375b
@arkpar
Propagate only one last hash for peers that are too far behind
fc7483a
@arkpar
Fixed panic on accessing expired node
61c52f1
@arkpar
Fixed panic on accessing expired node
38f4a06
@arkpar
Merge branch 'net' into discovery
986448c
@arkpar
Node table persistency
186c758
@arkpar
Merge branch 'master' of github.com:ethcore/parity into discovery
ba95260
@arkpar
Node table tests
cf45d59
@arkpar
Discovery test
4d40991
@arkpar arkpar added the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Feb 15, 2016
@NikVolf
Copy link
Contributor

NikVolf commented Feb 17, 2016

discovery.rs is rather small itself
yet the amount of changes in the pr is overhelming
maybe we should target to produce more feature-centric prs ;)

@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 17, 2016
@gavofyork
Copy link
Contributor

maybe we should target to produce more feature-centric prs ;)

+1

@gavofyork
Copy link
Contributor

additional tests needed for coveralls to give the go-ahead

@gavofyork gavofyork added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Feb 17, 2016
@arkpar arkpar mentioned this pull request Feb 18, 2016
Closed
3 tasks
@arkpar
Copy link
Collaborator Author

arkpar commented Feb 19, 2016

I've added as much testing as possible. Coverage reporting is broken imo, notice the coverage diff between two last commits.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Feb 19, 2016
@arkpar arkpar mentioned this pull request Feb 19, 2016
Merged
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 19, 2016
@NikVolf
Copy link
Contributor

NikVolf commented Feb 19, 2016

"though coverage is nice when green, it's only metrics and not a goal" (c)

gavofyork pushed a commit that referenced this pull request Feb 19, 2016
Merge pull request #440 from ethcore/discovery
6518576 
UDP Discovery
@gavofyork gavofyork merged commit 6518576 into master Feb 19, 2016
@arkpar arkpar mentioned this pull request Feb 20, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkpar @NikVolf @gavofyork