This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Vault Management UI (first round) #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
M7-ui
labels
Feb 6, 2017
jacogr
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
labels
Feb 10, 2017
jacogr
added
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Feb 14, 2017
jacogr
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
labels
Feb 14, 2017
@ngotchac / @derhuerst any comments before merge? |
i'll presume the silence means lgtm. |
gavofyork
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Feb 20, 2017
This was referenced Feb 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates Vault management capabilities into the UI, closes #4452 (UI portion of #3501). Includes -
modals/VaultCreate
- create vaults with their metadatamodals/VaultAccounts
- assign/de-assign accounts to a vaultmodals/VaulLock
- closes/locks a previously opened vaultmodals/VaultUnlock
- opens/unlocks a closed vaultviews/Vaults
accessible from the Accounts viewui/VaultCard
card to display a single vaultui/{Container,Title,ConfirmDialog}
tie-in changes for display via PortalFuture work & enhancements before 1.6 -
meta.{description, passwordHint}
)meta.vault
)In action -
https://youtu.be/JWc01XWPf9U