Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Vault Management UI (first round) #4446

Merged
merged 57 commits into from
Feb 20, 2017
Merged

Vault Management UI (first round) #4446

merged 57 commits into from
Feb 20, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Feb 6, 2017

Integrates Vault management capabilities into the UI, closes #4452 (UI portion of #3501). Includes -

  • modals/VaultCreate - create vaults with their metadata
  • modals/VaultAccounts - assign/de-assign accounts to a vault
  • modals/VaulLock - closes/locks a previously opened vault
  • modals/VaultUnlock - opens/unlocks a closed vault
  • views/Vaults accessible from the Accounts view
    • includes the store for managing vault information
  • ui/VaultCard card to display a single vault
  • ui/{Container,Title,ConfirmDialog} tie-in changes for display via Portal

Future work & enhancements before 1.6 -

  • Change of password for Vaults
  • Edit of metadata for Vaults (meta.{description, passwordHint})
  • Display of associated vault under Account properties & summary (meta.vault)
  • Allow moving account to vault in account summary pages
  • Selection of vault on account creation

In action -

https://youtu.be/JWc01XWPf9U

parity 2017-02-10 14-37-42

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Feb 6, 2017
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Feb 10, 2017
@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 14, 2017
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Feb 14, 2017
@jacogr jacogr changed the title Vault Management UI Vault Management UI (first round) Feb 15, 2017
@gavofyork
Copy link
Contributor

@ngotchac / @derhuerst any comments before merge?

@gavofyork
Copy link
Contributor

i'll presume the silence means lgtm.

@gavofyork gavofyork merged commit 9e210e5 into master Feb 20, 2017
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 20, 2017
@jacogr jacogr deleted the jg-vaults branch February 27, 2017 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI for Vaults management
2 participants