Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix ethstore build #4492

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Fix ethstore build #4492

merged 1 commit into from
Feb 9, 2017

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Feb 9, 2017

Cargo 0.16.0 no longer builds ethstore binary with cargo -p ethstore.
cargo -p ethstore --bin ethstore does not work either.

@arkpar arkpar added M1-ci 🙉 Continuous integration. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M0-build 🏗 Building and build system. and removed M1-ci 🙉 Continuous integration. labels Feb 9, 2017
@tomusdrw
Copy link
Collaborator

tomusdrw commented Feb 9, 2017

I have another fix for this, just add:

# ethstore/Cargo.toml

[lib]

[[bin]]
name = "ethstore"
path = "src/bin/main.rs"
doc = false

@arkpar
Copy link
Collaborator Author

arkpar commented Feb 9, 2017

Turns out the binary is built anyway, just to a different path. The [[bin]] section is in the toml file already.

@gavofyork gavofyork merged commit 3da3e84 into master Feb 9, 2017
@gavofyork gavofyork deleted the ethstore-fix branch February 9, 2017 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M0-build 🏗 Building and build system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants