This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Close on double-click for Signer Account selection #4540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Feb 14, 2017
| this.defaultAccount = defaultAccount; | ||
| transaction(() => { | ||
| this.accounts = this.accounts.map((account) => { | ||
| account.default = account.address === this.defaultAccount; |
There was a problem hiding this comment.
Is this correct? It basically sets the default to the previous default, i.e. this.defaultAccount is previous version since default is only set afterwards. Looks wrong. (If correct, a NOTE explanation may be in order here)
jacogr
reviewed
Feb 14, 2017
| return this._api.parity | ||
| .setNewDappsWhitelist(accounts) | ||
| .catch((error) => { | ||
| console.warn('makeDefaultAccount', error); | ||
| }); | ||
| } | ||
|
|
||
| loadDefaultAccount () { |
There was a problem hiding this comment.
It would probably make sense to add this to the spec.js as well (since the store is more-or-less tested already)
jacogr
added
A5-grumble 🔥
ngotchac
added
A0-pleasereview 🤓
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4525
Close only on double-click. Change default on simple click.
Also update the default in an optimistic way (not waiting for network request). The request will be valid 99% of the time. If not, it will just be reverted.