Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Revert Double Click on Accounts to close in Signer Bar #4590

Merged
merged 1 commit into from
Feb 17, 2017

Conversation

ngotchac
Copy link
Contributor

No description provided.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Feb 17, 2017
@jacogr
Copy link
Contributor

jacogr commented Feb 17, 2017

Not quite revert, rather "close on click". Feels good though.

@jacogr jacogr closed this Feb 17, 2017
@jacogr jacogr reopened this Feb 17, 2017
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 17, 2017
@ngotchac
Copy link
Contributor Author

(Revert because it used to be click => change & close, changed to click => change ; double-click => change & close after #4525)

@jacogr
Copy link
Contributor

jacogr commented Feb 17, 2017

Ummm, it used to be click to select without closing. (Which is why the original was logged, somewhere either the close didn't work or was added. Looked at your PR and you are right, so not sure why/when)

Either way, this way around does tick the boxes.

@gavofyork gavofyork merged commit 04f3ee9 into master Feb 17, 2017
@gavofyork gavofyork deleted the ng-revert-dbl-click branch February 17, 2017 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants