Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Enable --warp by default #4719

Merged
merged 4 commits into from
Mar 2, 2017
Merged

Enable --warp by default #4719

merged 4 commits into from
Mar 2, 2017

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Mar 2, 2017

No description provided.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 2, 2017
@gavofyork
Copy link
Contributor

does this interact well with --tracing &c.?

@arkpar
Copy link
Collaborator Author

arkpar commented Mar 2, 2017

--tracing, --fatdb, etc would start collecting data from the restoration point. I agree that this makes little sense. Fixed in the latest commit.

@gavofyork
Copy link
Contributor

ok - one final thing: if the user states --warp while also configuring it (either through CLI or past options) tracing, fat db or archive then it should warn them that warp is disabled due to these.

@arkpar arkpar added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 2, 2017
@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Mar 2, 2017
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 2, 2017
@gavofyork gavofyork merged commit 591eb76 into master Mar 2, 2017
@gavofyork gavofyork deleted the warp-default branch March 2, 2017 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants