Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix paste in Inputs #4844

Merged
merged 2 commits into from
Mar 10, 2017
Merged

Fix paste in Inputs #4844

merged 2 commits into from
Mar 10, 2017

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Mar 9, 2017

Fixes #4751

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Mar 9, 2017
@jacogr
Copy link
Contributor

jacogr commented Mar 10, 2017

As discussed, we need to think about the timeouts, there must be a cleaner way. As it stands, does solve the issue at hand.

@jacogr jacogr added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 10, 2017
@jacogr jacogr merged commit d98b7aa into master Mar 10, 2017
@jacogr jacogr deleted the ng-fix-paste-input branch March 10, 2017 10:52
@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Mar 10, 2017
@ngotchac
Copy link
Contributor Author

ngotchac commented Mar 10, 2017 •
edited
Loading

I actually added what we talked about @jacogr ; seems to work and is a bit cleaner. I also implemented the TODO : revert to initial value on ESC

(see #4854)

@ngotchac ngotchac mentioned this pull request Mar 10, 2017
Merged
jacogr pushed a commit that referenced this pull request Mar 10, 2017
@ngotchac @jacogr
Wait for the value to have changed in the input (#4844)
a069074
@jacogr jacogr mentioned this pull request Mar 10, 2017
Merged
arkpar pushed a commit that referenced this pull request Mar 10, 2017
@jacogr @arkpar
[beta] UI backports (#4855)
ab23669 
* Added React Hot Reload to dapps + TokenDeplpoy fix (#4846)

* Fix method decoding (#4845)

* Fix contract deployment method decoding in Signer

* Linting

* Fix TxViewer when no `to` (contract deployment) (#4847)

* Added React Hot Reload to dapps + TokenDeplpoy fix

* Fixes to the LocalTx dapp

* Don't send the nonce for mined transactions

* Don't encode empty to values for options

* Pull steps from actual available steps (#4848)

* Wait for the value to have changed in the input (#4844)

* Backport Regsirty changes from #4589

* Test fixes for #4589
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A0-pleasereview 🤓 Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngotchac @jacogr @gavofyork