Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Safari Dialog scrolling fix #4893

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Safari Dialog scrolling fix #4893

merged 1 commit into from
Mar 14, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Mar 14, 2017

  • Move ParityBackground on Portal z-index to -1 (despite being 0/lower, it still overlays in Safari)
  • Confirm to fix dialog non-scrolling issues in Safari, also tested on Chrome (no additional effects)
  • Evaluated/tested on FirstRun and create dialogs

Fixes https://github.com/ethcore/parity/issues/4890

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. B0-patch labels Mar 14, 2017
@jacogr jacogr mentioned this pull request Mar 14, 2017
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 14, 2017
@gavofyork gavofyork merged commit e12bde8 into master Mar 14, 2017
@gavofyork gavofyork deleted the jg-safari-scroll branch March 14, 2017 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants