Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

splitting part of util into smaller crates #4956

Merged
merged 8 commits into from
Mar 22, 2017
Merged

splitting part of util into smaller crates #4956

merged 8 commits into from
Mar 22, 2017

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 18, 2017 •
edited
Loading

related #1803

  • moved RotatingLogger from ethcore-util to ethcore-logger
  • created new crate path and moved path.rs module there
  • ethcore-logger is not dependant on ethcore-util any more
  • updated ansi_term and arrayvec crates

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 18, 2017
@debris debris requested a review from rphmeier March 18, 2017 15:44
@debris debris added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 18, 2017
@debris debris added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Mar 18, 2017
@debris debris mentioned this pull request Mar 21, 2017
Merged
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 21, 2017
@gavofyork gavofyork added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Mar 21, 2017
@debris debris merged commit d530cc8 into master Mar 22, 2017
@debris debris deleted the util_split branch March 22, 2017 05:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rphmeier rphmeier Awaiting requested review from rphmeier

Assignees
No one assigned
Labels
A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @gavofyork @arkpar