Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Various installer and tray apps fixes #4970

Merged
merged 2 commits into from
Mar 23, 2017
Merged

Various installer and tray apps fixes #4970

merged 2 commits into from
Mar 23, 2017

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Mar 20, 2017

No description provided.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. B0-patch M2-installer 📲 Installers for MacOS and Windows. M4-core ⛓ Core client code / Rust. labels Mar 20, 2017
parity/main.rs Outdated
// When restarting in the same process this reinits windows sockets.
unsafe {
let mut wsdata: ::winapi::winsock2::WSADATA = ::std::mem::zeroed();
::ws2_32::WSAStartup(0x202, &mut wsdata);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x202? Could be an informative constant

@arkpar arkpar force-pushed the tray-apps branch 2 times, most recently from 89a9dd1 to 7d48129 Compare March 22, 2017 11:43
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 23, 2017
@gavofyork gavofyork merged commit f5ea47a into master Mar 23, 2017
@gavofyork gavofyork deleted the tray-apps branch March 23, 2017 12:25
@arkpar arkpar removed the B0-patch label Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M2-installer 📲 Installers for MacOS and Windows. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants