This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixing secretstore TODOs - part 2 #5416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A3-inprogress ⏳
|
svyatonik
added
A0-pleasereview 🤓
|
lgtm and seems to work. |
rphmeier
reviewed
Apr 19, 2017
| impl<T> Drop for KeyServerHttpListener<T> where T: KeyServer + 'static { | ||
| fn drop(&mut self) { | ||
| // ignore error as we are dropping anyway | ||
| let _ = self._http_server.close(); |
There was a problem hiding this comment.
does this not close on drop already?
There was a problem hiding this comment.
Nope. That was the rason behind "Fixed closing Parity by ^C when secretstore was working" issue. You must call close() explicitely
rphmeier
reviewed
Apr 21, 2017
| /// 1) checks if connected nodes are responding to KeepAlive messages | ||
| /// 2) tries to connect to disconnected nodes | ||
| /// 3) checks if enc/dec sessions are time-outed | ||
| const MAINTAN_INTERVAL: u64 = 10; |
rphmeier
added
A8-looksgood 🦄
keorn
approved these changes
Apr 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #5386
Most of still pending TODOs are fixed here, including:
I want to add some tests for these fixes, so marking as in-progress.