This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Secretstore RPCs + integration #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A0-pleasereview 🤓
|
@keorn done |
keorn
added
A8-looksgood 🦄
keorn
reviewed
May 3, 2017
rpc/src/v1/traits/secretstore.rs
Outdated
| /// Parity-specific rpc interface. | ||
| pub trait SecretStore { | ||
| /// Encrypt data with key, received from secret store. | ||
| /// Arguments: `account`, `key`, `data`. |
keorn
reviewed
May 3, 2017
rpc/src/v1/traits/secretstore.rs
Outdated
| fn encrypt(&self, H160, String, Bytes, Bytes) -> Result<Bytes, Error>; | ||
|
|
||
| /// Decrypt data with key, received from secret store. | ||
| /// Arguments: `account`, `key`, `data`. |
keorn
reviewed
May 3, 2017
rpc/src/v1/traits/secretstore.rs
Outdated
| fn decrypt(&self, H160, String, Bytes, Bytes) -> Result<Bytes, Error>; | ||
|
|
||
| /// Decrypt data with shadow key, received from secret store. | ||
| /// Arguments: `account`, `decrypted_secret`, `common_point`, `decrypt_shadows`, `data`. |
gavofyork
added
A6-mustntgrumble 💦
keorn
added
A8-looksgood 🦄
|
Tests fail seems unrelated, because only docs were changed in @keorn commit, but it fails, while previous - does not. |
|
conflicts? |
gavofyork
added
A7-looksgoodcantmerge 🙄
svyatonik
added
A0-pleasereview 🤓
keorn
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #5416
This is PR for RPCs && small changes required for easier secretstore integration.
First change, as suggested by @ngotchac is to use ethcrypto::encrypt/decrypt with known MAC instead of ethcrypto::{encrypt/decrypt}_single_message. This will help with using RPCs like
parity_decryptMessage.@ngotchac I've slightly changed your commit && moved DEFAULT_MAC to ethcrypto from bith RPC && SecretStore modules. Hope you're ok with that :)