Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Bump jsonrpc version #5489

Merged
merged 3 commits into from
Apr 25, 2017
Merged

Bump jsonrpc version #5489

merged 3 commits into from
Apr 25, 2017

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Apr 21, 2017

should address #5470

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Apr 21, 2017
@NikVolf NikVolf added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 25, 2017
@NikVolf NikVolf merged commit 9d6c50e into master Apr 25, 2017
@NikVolf NikVolf deleted the update-jsonrpc branch April 25, 2017 16:48
@rphmeier
Copy link
Contributor

Calling this an insubstantial isn't really accurate. Obviously the change here corresponds to some changes in code, but the linked issue also doesn't give any indication of what changed. I think it would be better to give a description of changes made and a link to code for this kind of PR in the future, since as-is it's pretty clear that nobody reviewed it but it's now in master.

@NikVolf
Copy link
Contributor Author

NikVolf commented Apr 25, 2017

Well it was reviewed in jsonrpc crate
Here the diff shows nothing, so there is nothing to discuss and comment really

@rphmeier
Copy link
Contributor

Right, my point is that the corresponding PR should be linked to when we do bumps like this since there's usually more eyes on the PRs here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants