This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Pass additional data when reporting #5527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keorn
added
A0-pleasereview 🤓
rphmeier
reviewed
May 2, 2017
| // Returns the double voting address. | ||
| full_vote(&collector, H520::random(), round, Some("1".sha3()), &Address::default()).unwrap(); | ||
| assert!(!full_vote(&collector, H520::random(), round, Some("1".sha3()), &Address::default())); |
There was a problem hiding this comment.
these two full_vote calls have different block hashes. can you clarify why it's still a double vote?
There was a problem hiding this comment.
this is what a double vote is: voting for two different hashes in the same voting round.
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the reporting validator set interface. Updated contracts.
Not 100% sure if this is the right balance between structured and unstructured args, malicious proofs will take on very different forms most likely.