This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Proper signer Pub-Sub for pending requests. #5594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
rphmeier
reviewed
May 16, 2017
rpc/src/v1/impls/signer.rs
Outdated
| if let (Some(s), Some(subs)) = (s.upgrade(), subs.upgrade()) { | ||
| for subscription in subs.lock().values() { | ||
| let subscription: &Sink<_> = subscription; | ||
| let _ = subscription.notify(s.requests() |
There was a problem hiding this comment.
this seems like it could be a pretty heavy operation. couldn't we perform the conversion once and pass a slice to to notify instead?
There was a problem hiding this comment.
Good point, thanks. Updated to clone the results instead and also added an event loop instead of .wait().
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.