This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to guanqun-add-unit-tests
gavofyork
added
A0-pleasereview 🤓
Pull request needs code review.
M4-core ⛓
Core client code / Rust.
labels
May 20, 2017
Merged
not building properly. @General-Beck ? |
gavofyork
added
A4-gotissues 💥
Pull request is reviewed and has significant issues which must be addressed.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
May 20, 2017
I used |
@guanqun https://gitlab.parity.io/parity/parity/builds/54720 indicates that the build was skipped because it modified no Rust files, which definitely isn't true. I'll try retrying |
aha, I think I know the problem, here's the fix for it. 14b715b The original script only detects for "^js", interesting enough, I'm modifying "json"... But I don't have permission to push to |
…to guanqun-add-unit-tests
gavofyork
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A4-gotissues 💥
Pull request is reviewed and has significant issues which must be addressed.
labels
May 23, 2017
This is really great, thanks a lot! |
arkpar
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
May 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.