Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Guanqun add unit tests #5671

Merged
merged 15 commits into from
May 23, 2017
Merged

Guanqun add unit tests #5671

merged 15 commits into from
May 23, 2017

Conversation

gavofyork
Copy link
Contributor

No description provided.

@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels May 20, 2017
@gavofyork gavofyork mentioned this pull request May 20, 2017
@gavofyork
Copy link
Contributor Author

not building properly. @General-Beck ?

@gavofyork gavofyork added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 20, 2017
@guanqun
Copy link
Contributor

guanqun commented May 20, 2017

I used cargo test -p ethjson and it worked fine locally. What's the issue? I see "All checks have passed" from CI.

@rphmeier
Copy link
Contributor

rphmeier commented May 20, 2017

@guanqun https://gitlab.parity.io/parity/parity/builds/54720 indicates that the build was skipped because it modified no Rust files, which definitely isn't true. I'll try retrying

@guanqun
Copy link
Contributor

guanqun commented May 21, 2017

aha, I think I know the problem, here's the fix for it. 14b715b

The original script only detects for "^js", interesting enough, I'm modifying "json"...

But I don't have permission to push to guanqun-add-unit-tests, probably someone can cherry-pick this commit.

@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels May 23, 2017
@arkpar
Copy link
Collaborator

arkpar commented May 23, 2017

This is really great, thanks a lot!

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 23, 2017
@rphmeier rphmeier merged commit 18c3e90 into master May 23, 2017
@rphmeier rphmeier deleted the guanqun-add-unit-tests branch May 23, 2017 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants