Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update dependencies and bigint api #5685

Merged
merged 8 commits into from
May 24, 2017
Merged

Update dependencies and bigint api #5685

merged 8 commits into from
May 24, 2017

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented May 23, 2017 •
edited
Loading

related to #5667

@NikVolf NikVolf added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M4-core ⛓ Core client code / Rust. labels May 23, 2017
@NikVolf
Copy link
Contributor Author

NikVolf commented May 23, 2017

waiting on debris/elastic-array#4

@debris
Copy link
Collaborator

debris commented May 23, 2017

@NikVolf merged and released version 0.8

@NikVolf NikVolf changed the title Update to latest bigint api Update dependencies and bigint api May 23, 2017
@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels May 23, 2017
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 23, 2017
@NikVolf NikVolf closed this May 23, 2017
@NikVolf NikVolf reopened this May 23, 2017
@rphmeier
Copy link
Contributor

The whole bigint/ethcore-bigint crate situation is confusing. We should break these into parity-bigint and parity-fixedhash and publish both on crates.io in separate repos along with RLP.

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. and removed A8-looksgood 🦄 Pull request is reviewed well. labels May 23, 2017
@NikVolf NikVolf requested review from debris and tomusdrw May 23, 2017 20:35
@NikVolf
Copy link
Contributor Author

NikVolf commented May 23, 2017

latest commit was reviewed in #5686

@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 23, 2017
tomusdrw
tomusdrw approved these changes May 24, 2017
View reviewed changes
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

util/src/journaldb/earlymergedb.rs Outdated
@@ -23,6 +23,7 @@ use memorydb::*;
use super::{DB_PREFIX_LEN, LATEST_ERA_KEY};
use super::traits::JournalDB;
use kvdb::{KeyValueDB, DBTransaction};
use heapsize::HeapSizeOf;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be re-exported from bigint?

@arkpar arkpar merged commit e1fef5c into master May 24, 2017
@arkpar arkpar deleted the bigint-update branch May 24, 2017 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rphmeier rphmeier rphmeier approved these changes

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NikVolf @debris @rphmeier @tomusdrw @arkpar