two small changes in evm

[guanqun]

• add one unit test for is_push in instructions.rs
• split VMType into a separate file as suggested by the TODO in factory.rs (no functional changes)

[tomusdrw]

LGTM, but I'm pretty sure you need to update EVM tests and EVMbin cause it's also using VMType.

[guanqun]

evmbin doesn't seem to use VMType, I did a quick grep:

➜  parity $ cd evmbin
➜  evmbin $ git grep VMType

The main two folders that are using VMType are ethcore and parity

$ git grep VMType | tr "/" " " | awk '{ print $1}' | sort | uniq
ethcore
parity

And these two components can cargo build and cargo test properly. So I think it's fine.

Code-wise, in evm/mod.rs, I'm pulling the VMType directly into evm module, and that's the same behavior as before. As long as other code is using evm::VMType instead of evm::factory::VMType, then we're fine. :)

EDIT: grep how we use the module:

git grep "use.*evm::.*VMType"
ethcore/src/client/config.rs:pub use evm::VMType;
ethcore/src/client/evm_test_client.rs:use evm::{self, VMType};
ethcore/src/client/test_client.rs:use evm::{Factory as EvmFactory, VMType, Schedule};
ethcore/src/evm/benches/mod.rs:use evm::{self, Factory, VMType};
ethcore/src/evm/tests.rs:use evm::{self, Ext, Schedule, Factory, GasLeft, VMType, ContractCreateResult, MessageCallResult, CreateContractAddress};
ethcore/src/executive.rs:       use evm::{Factory, VMType, CreateContractAddress};
ethcore/src/json_tests/executive.rs:use evm::{Schedule, Ext, Factory, Finalize, VMType, ContractCreateResult, MessageCallResult, CreateContractAddress};

Looks like we don't need to change the downstream code.

[guanqun]

Do we have other external repo that depends on this?

BTW: How can I trigger an integration build for this PR?

[rphmeier]

style: separate public modules from private modules with whitespace

[guanqun]

Sure, moved down a bit.

[rphmeier]

style: docs over attributes

[guanqun]

Fixed.

[NikVolf]

#5718
for the CI check

[gavofyork]

谢谢!

[guanqun]

不用谢 :)