Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

use NULL_RLP, remove NULL_RLP_STATIC #5742

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Conversation

guanqun
Copy link
Contributor

@guanqun guanqun commented Jun 1, 2017

I thought NULL_RLP_STATIC was created for a reason, but I can't think of the specific reason, even the Rust book suggests we should prefer const. So this PR, but maybe it has other reasons, then feel free to close this PR.

cargo build and cargo test both seem ok.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jun 1, 2017
@rphmeier
Copy link
Contributor

rphmeier commented Jun 1, 2017

LGTM, still working on getting CI up for out-of-org PRs! Thanks for your patience and repeated contributions :)

@guanqun
Copy link
Contributor Author

guanqun commented Jun 2, 2017

Thank you all to come up with this great project. For me, I'm only able to work on this part time (limited time per day), so bear with me to create these small/trivial PRs. Hopefully when I get more familiar with the whole codebase, I can send bigger PR.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 7, 2017
@arkpar arkpar merged commit 05aa960 into openethereum:master Jun 7, 2017
@guanqun guanqun deleted the null-rlp branch June 7, 2017 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants