This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
ArchiveDB and other small fixes #5867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
rphmeier
reviewed
Jun 18, 2017
| @@ -296,6 +296,7 @@ mod test { | |||
| assert!(check_vault_name("vault_with_underscores")); | |||
| assert!(check_vault_name("vault-with-dashes")); | |||
| assert!(check_vault_name("vault-with-digits-123")); | |||
| assert!(check_vault_name("vault中文名字")); | |||
There was a problem hiding this comment.
good idea to check that unicode works fully :)
rphmeier
reviewed
Jun 18, 2017
| jdb.remove(&h); | ||
| jdb.remove(&h); | ||
| // commit_batch would call journal_under(), | ||
| // and we don't allow multiple owned removals. |
There was a problem hiding this comment.
semantics of journaldb are a little weird as it never deletes the key from the backing store, so it actually wouldn't panic if the two removals were done on opposite sides of a journal_under operation...but as this test it will panic if you remove twice in a single batch.
There was a problem hiding this comment.
Yes, I deliberately remove twice in a single batch and so mark this test as should_panic. This basically tests the assert logic, if you think it's un-necessary, I can revert this change.
There was a problem hiding this comment.
can't hurt to have the test case -- it will let us know if that behavior changes.
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases, spaces to tab etc.