This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixed one more case of sync stalling #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -475,7 +475,7 @@ impl ChainSync { | |||
| peer.latest_number = Some(header.number()); | |||
| } | |||
| // TODO: Decompose block and add to self.headers and self.bodies instead | |||
| if header.number == From::from(self.current_base_block() + 1) { | |||
| if header.number <= From::from(self.current_base_block() + 1) { | |||
There was a problem hiding this comment.
Allow import of stale NewBlocks
|
The sync could stall in case a block body download request is issued and while it is active a NewBlock arrives with the same block and the body request times out. |
gavofyork
added
A8-looksgood 🦄
gavofyork
pushed a commit
that referenced
this pull request
Mar 4, 2016
Fixed one more case of sync stalling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.