This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Multi-call RPC #6195
Merged
Multi-call RPC #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
rphmeier
reviewed
Jul 31, 2017
| @@ -389,4 +389,8 @@ impl Parity for ParityClient { | |||
| fn ipfs_cid(&self, content: Bytes) -> Result<String, Error> { | |||
| ipfs::cid(content) | |||
| } | |||
|
|
|||
| fn call(&self, _requests: Vec<CallRequest>, _block: Trailing<BlockNumber>) -> BoxFuture<Vec<Bytes>, Error> { | |||
| future::err(errors::light_unimplemented(None)).boxed() | |||
There was a problem hiding this comment.
implementation of this function will be tricky as discussed w/ @tomusdrw
arkpar
reviewed
Aug 2, 2017
| @@ -907,7 +907,7 @@ impl Client { | |||
| pub fn state_at(&self, id: BlockId) -> Option<State<StateDB>> { | |||
| // fast path for latest state. | |||
| match id.clone() { | |||
| BlockId::Pending => return self.miner.pending_state().or_else(|| Some(self.state())), | |||
| BlockId::Pending => return self.miner.pending_state(self.chain.read().best_block_number()).or_else(|| Some(self.state())), | |||
There was a problem hiding this comment.
Why is block number required here? Does not the miner know the best pending state already?
There was a problem hiding this comment.
The issue is that the pending state might be stalled, so we check that by comparing block numbers.
We had a similar thing earlier (at least for RPC), but the behaviour was very inconsistent - some stuff was going via the client and some via RPC.
arkpar
added
A8-looksgood 🦄
tomusdrw
added
A0-pleasereview 🤓
debris
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes duplicated state-touching methods in miner, now client can forward all pending-block queries correctly if pending state is available and otherwise falls back to
lateststate.Introduces
parity_callandtrace_callManyallowing to run many non-persistent, but dependent calls on a state (for instance deploy contract + query a function from that contract).CC @kaikun213
@paritytech/core-devs Let me know if you prefer to review miner-client refactoring separetly from the feature I can split the PRs.