This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Don't call mark_as_bad needlessly #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A8-looksgood 🦄
| @@ -404,8 +404,12 @@ impl<V> Client<V> where V: Verifier { | |||
|
|
|||
| { | |||
| let mut block_queue = self.block_queue.write().unwrap(); | |||
| block_queue.mark_as_bad(&bad_blocks); | |||
| block_queue.mark_as_good(&good_blocks); | |||
| if !bad_blocks.is_empty() { | |||
There was a problem hiding this comment.
Is it worth checking in both places? Why do you check here also?
There was a problem hiding this comment.
Inside - to protect from invalid use outside
Outside - to protect from inefficient implementation inside )
There was a problem hiding this comment.
I would rather leave comment Inside to explain why it's better not to remove it (or maybe it's possible to write test that empty list should rearrange?)
But LGTM anyway.
There was a problem hiding this comment.
After the rearrange it's the same queue, just some time wasted
tomusdrw
added a commit
that referenced
this pull request
Mar 10, 2016
Don't call mark_as_bad needlessly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling shows calls to
mark_as_badtake significant time because inside there is a rearrangement of the verification queue even if the list of bad blocks is empty.