Fix #6540

[travs]

Skips the checkRequest call if result of postTransaction is a tx ID.
If there is a better way to check whether result is a tx ID than looking at its length, let's do that.

Made a similar PR over here, but I can't even get the module installed from that repo, and the latest changes are not as new as those in this repo, so it looks like this one makes more sense to merge to.

[parity-cla-bot]

It looks like @travs signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

[travs]

Not sure why I keep getting this failing build.
I really don't think it is to do with my change.
I'm branching from master; is this the wrong thing to do?

[jacogr]

Failures fixed in #6553

[travs]

@jacogr
Copy that. Will rebase this guy when #6553 merges

[gavofyork]

done

[travs]

Rebased and ready to merge (if it passes 🤞 )

[jacogr]

Why did we lose the requestId naming? This is is that the holder of the statecb checks the requestId field which does not exist anywhere anymore.

[travs]

oh yeah that's my mistake, one sec I will revise

[travs]

revised 9deac99

[jacogr]

LGTM

As for the parity.js repo, it will be removed in favour of the js-{abi, api} repos. (I do keep those updated from master, at this point they are direct match* for what is found there, in the short term they will become the only source of truth.)

• Almost a direct match. Some changes have been made to allow them to be used as-is from both the web and node environments without a compilation step. (Basically makes them easier to embed/use)

[travs]

@jacogr Ok great. I want to use js-api from node so I can just install via the instructions in the readme here?

[jacogr]

@travs Will update the instructions.

But basically, not published to npm (yet, we are busy working through that with CI, will be in the next week or so), so for now would just need to have a github package.json entry: (Also the way we use it atm with out next-generation UI until the package is published)

{
  ...
  "dependencies" {
    "@parity/api": "paritytech/js-api"
    ...
  }
  ...
}

Then just use it as you would the normal parity.js, i.e.

const ParityApi = require('@parity/api");

// Only difference here to the previous version:
// Transport changed to Provider to align with web3/metamask/next-gen
// (Could also push in the web3 provider once they support the new .send() interface shortly
// PS: Could still use Transport as per normal, it will just show a warning message
const parity = new ParityApi(new ParityApi.Provider.Http('...'));