Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

SecretStore: exclusive sessions #6624

Merged
merged 5 commits into from
Oct 5, 2017
Merged

Conversation

svyatonik
Copy link
Collaborator

ServersSetChange session can't be started if there are some sessions active.
Any session can't be started if ServersSetChange session is active.

Alternative implementation: wait() on all active sessions until requested session can be started. Haven't implemented this, because:

  1. signing/decryption/generation/encryption sessions are started by HTTP request && client could possibly get timeout error before wait() is completed => lost hash=>key entry (in case of generation session) + a lot of duplicate decryption/signing sessions (if he's retries)
  2. ServersSetChange can take a lot of time (when there are a lot of keys in SS) && it is better (imho) to fail asap
  3. server we are requesting, can be excluded from SS when ServersSetChange session is completed => session will fail anyway

@svyatonik svyatonik added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 3, 2017
@svyatonik
Copy link
Collaborator Author

It is TODO6 from #6605

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 5, 2017
@debris debris merged commit d8094e0 into master Oct 5, 2017
@debris debris deleted the secretstore_exclusive_sessions branch October 5, 2017 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants