Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Client module overhaul #665

Merged
merged 6 commits into from
Mar 11, 2016
Merged

Client module overhaul #665

merged 6 commits into from
Mar 11, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 10, 2016

no logic has been changed.

changes

  • created ethcore/src/client directory
  • moved BlockChainClient trait from client.rs to client/mod.rs
  • moved ClientConfig structure from client.rs to client/config.rs
  • moved BlockId and TransactionId from client.rs to client/ids.rs
  • moved TestBlockChainClient from sync/src/tests/helpers.rs to ethcore/src/client/test_client.rs (jsonrpc tests will need it)

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Mar 10, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Mar 10, 2016
@debris debris mentioned this pull request Mar 11, 2016
Merged
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Mar 11, 2016
NikVolf added a commit that referenced this pull request Mar 11, 2016
@NikVolf
Merge pull request #665 from ethcore/client_submodules
62e94e1 
Client module overhaul
@NikVolf NikVolf merged commit 62e94e1 into master Mar 11, 2016
@debris debris deleted the client_submodules branch March 11, 2016 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debris @NikVolf