This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Prevent going offline when restoring or taking a snapshot #6694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
rphmeier
reviewed
Oct 11, 2017
ethcore/src/client/client.rs
Outdated
| snapshot::take_snapshot(&*self.engine, &self.chain.read(), start_hash, db.as_hashdb(), writer, p)?; | ||
| self.taking_snapshot.store(false, AtomicOrdering::Relaxed); |
There was a problem hiding this comment.
prefer AcqRel or stronger. it's not a bottleneck and Relaxed is fine but it's better not to use it in general.
|
When taking a snapshot it should be fine though, since that doesn't draw from the network. Actually if you go offline halfway through it will be more likely to succeed because states are less likely to be pruned out. |
|
@rphmeier good point |
debris
added
A8-looksgood 🦄
debris
approved these changes
Oct 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6484