Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Graceful exit when invalid CLI flags are passed (#6485) #6711

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Graceful exit when invalid CLI flags are passed (#6485) #6711

merged 1 commit into from
Oct 12, 2017

Conversation

axelchalon
Copy link
Contributor

@axelchalon axelchalon commented Oct 11, 2017 •
edited
Loading

Fixes #6485 (due to a bug in Clap; filed issue clap-rs/clap#1066)

tomusdrw
tomusdrw approved these changes Oct 11, 2017
View reviewed changes
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it also fail if you provide invalid values to flags?

Like:

$ parity --cache asd

@axelchalon
Copy link
Contributor Author

axelchalon commented Oct 11, 2017 •
edited
Loading

doesn't crash on this invalid value (we just saw that it has been this way since the port to clap); I will look into this and do another PR

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 11, 2017
@5chdn 5chdn added this to the 1.8 milestone Oct 11, 2017
@5chdn 5chdn mentioned this pull request Oct 11, 2017
Closed
67 tasks
@debris debris merged commit fee68a5 into master Oct 12, 2017
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 12, 2017
@debris debris deleted the cli-unknownarguments-6485 branch October 12, 2017 13:52
@axelchalon
Copy link
Contributor Author

I just fixed parity not throwing an error on invalid values; I'll make a PR

@axelchalon
Copy link
Contributor Author

#6723

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@axelchalon @tomusdrw @debris @5chdn