Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Set zero nonce and gas price for calls by default #6954

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Set zero nonce and gas price for calls by default #6954

merged 1 commit into from
Nov 2, 2017

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Nov 1, 2017

Significantly improves call performance

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels Nov 1, 2017
@arkpar arkpar requested a review from tomusdrw November 1, 2017 11:37
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 1, 2017
tomusdrw
tomusdrw approved these changes Nov 1, 2017
View reviewed changes
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although we should note that in the docs in case someone is relying on those.

@tomusdrw tomusdrw added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Nov 1, 2017
@5chdn 5chdn added this to the 1.9 milestone Nov 1, 2017
@arkpar arkpar merged commit 60bb2d9 into master Nov 2, 2017
@arkpar arkpar deleted the call-no-gasprice branch November 2, 2017 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M6-rpcapi 📣 RPC API.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.
3 participants
@arkpar @tomusdrw @5chdn