Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix windows build (with ui rebuild) #7016

Merged
merged 3 commits into from
Nov 10, 2017
Merged

Fix windows build (with ui rebuild) #7016

merged 3 commits into from
Nov 10, 2017

Conversation

tomusdrw
Copy link
Collaborator

With some update of rustc running external npm command on windows stopped working.

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M0-build 🏗 Building and build system. labels Nov 10, 2017
@tomusdrw tomusdrw requested a review from jacogr November 10, 2017 10:01
jacogr
jacogr approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 10, 2017
@debris debris merged commit dd87b30 into master Nov 10, 2017
@debris
Copy link
Collaborator

debris commented Nov 10, 2017

@tomusdrw does it need to be backported?

@5chdn 5chdn added this to the 1.9 milestone Nov 10, 2017
@5chdn 5chdn deleted the td-glue branch January 3, 2018 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr jacogr approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M0-build 🏗 Building and build system.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.
4 participants
@tomusdrw @debris @jacogr @5chdn