This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Inject parity script to all dapps // Expand dapps to any ZIP file #7260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
approved these changes
Dec 11, 2017
dapps/src/tests/fetch.rs
Outdated
| @@ -167,13 +167,15 @@ fn should_return_fetched_dapp_content() { | |||
| response1.assert_status("HTTP/1.1 200 OK"); | |||
| assert_security_headers_for_embed(&response1.headers); | |||
| assert_eq!( | |||
There was a problem hiding this comment.
could use assert!(condition, format, params..) instead of assert_eq!(expression, true, format, params..)
hash-fetch/src/urlhint.rs
Outdated
| @@ -85,14 +89,16 @@ pub struct Content { | |||
| /// MIME type of the content | |||
| pub mime: Mime, | |||
| /// Content owner address | |||
| pub owner: Address, | |||
| pub owner: Address | |||
There was a problem hiding this comment.
In rust we try to have trailing commas after each line.
There was a problem hiding this comment.
Can't there be a linter for this?
There was a problem hiding this comment.
I'd love to have one, we tried using rustfmt some time ago, but there were many places were the formatting was a bit weird. We should give it a go again soon though!
hash-fetch/src/urlhint.rs
Outdated
| Content { | ||
| url: account_slash_repo, | ||
| mime: mime, | ||
| owner: owner |
There was a problem hiding this comment.
Could be simplified to:
Content {
url: account_slash_repo,
mime,
owner,
}
tomusdrw
added
A6-mustntgrumble 💦
tomusdrw
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR injects too all HTML files served by the dapps server the
parity.jsscript that instantiate a newwindow.ethereumProviderobject.It also adds the possibility to now link a dapp to a ZIP file (like a Github Release), instead of only the
repo+committuppleTo do that, one must set as the
commitfield in the GithubHint contract entry the value0x00..001. This is to prevent the dapp server to extract zip files that should remain zip files, and not dapps.