This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
SecretStore: secretstore_signRawHash method #7336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A0-pleasereview 🤓
tomusdrw
reviewed
Dec 21, 2017
| @@ -100,7 +101,29 @@ fn rpc_secretstore_shadow_decrypt() { | |||
| } | |||
|
|
|||
| #[test] | |||
| fn rpc_secretstore_sign_servers_set() { | |||
| fn rpc_secretstore_servers_set_hash() { | |||
| let deps = Dependencies::new(); | |||
There was a problem hiding this comment.
You can consider using new jsonrpc_test:
https://github.com/paritytech/jsonrpc/blob/master/test/src/lib.rs#L28
tomusdrw
added
A8-looksgood 🦄
debris
reviewed
Dec 29, 2017
| @@ -627,6 +626,7 @@ impl ApiSet { | |||
| public_list.insert(Api::ParityAccounts); | |||
| public_list.insert(Api::ParitySet); | |||
| public_list.insert(Api::Signer); | |||
| public_list.insert(Api::SecretStore); | |||
There was a problem hiding this comment.
just a question. Above you've added a comment SecretStore (UNSAFE: arbitrary hash signing), but here SecretStore is added to a SafeContext. Isn't it contradictory?
There was a problem hiding this comment.
I was also confused a bit :) If I understood correctly, there are:
- safe/unsafe APIs
- safe/unsafe API Contexts
So: SecretStore API is unsafe => it is only enabled when API context is safe. Here's couple of proofs I've found:
- https://github.com/paritytech/parity/blob/master/parity/rpc_apis.rs#L148 (reveres proof)
- ParityAccounts API, which is also unsafe, is included to the
SafeContextAPI set
There was a problem hiding this comment.
Yes, indeed that the reasoning, although It's extremely confusing (sorry about that:() Feel free to rename it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7248
Overview:
secretstore_signRawHashmethodsecretstore_signServersSet(semantics is changed also)secretstoreAPI set as unsafe, because it now allows to sign any passed raw hash (without prepending with the prefix && without applying hash function)secretstore_signRawHashcan now be used to sign the server key id, which was initially intended to be akeccak256(document_contents). It also should be used to sign the servers set hash after calling thesecretstore_serversSetHashmethod.