-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Move js & js-old code to github.com/parity-js #7685
Conversation
Cargo.lock
Outdated
@@ -2214,13 +2214,15 @@ dependencies = [ | |||
[[package]] | |||
name = "parity-ui-dev" | |||
version = "1.9.0" | |||
source = "git+https://github.com/parity-js/shell.git?rev=c4ad493b86fd8dda0364881d9cff39c95e2ee73b#c4ad493b86fd8dda0364881d9cff39c95e2ee73b" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This auto-gen line looks funny. (And the next one - not sure how/why there are 2 refs? Or rather what I assume to be refs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because you have set explicit rev
in Cargo.toml
file. Instead you could just set up github repo and let Cargo.lock
maintain the revision.
But it's fine, might be a bit more pain in the ass to update though:
1. edit Cargo.toml
2. Run $ cargo update -p parity-ui-dev
vs
$ cargo update -p parity-ui-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100%, bit more of a pain with the revs - this does feel safer since the shell will morph as we get closer to having it dapp-able.
(e.g. @amaurymartiny is working really hard on allowing the shell to be able to run as a dapp & Electron app #next
branch in that repo, if that goes to main it should already be fully removed from the 1.10 binary, but if not it is just easier to manage having a compatible know version based on rev)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, how do we plan to update the revisions though?
Cargo.lock
Outdated
@@ -2214,13 +2214,15 @@ dependencies = [ | |||
[[package]] | |||
name = "parity-ui-dev" | |||
version = "1.9.0" | |||
source = "git+https://github.com/parity-js/shell.git?rev=c4ad493b86fd8dda0364881d9cff39c95e2ee73b#c4ad493b86fd8dda0364881d9cff39c95e2ee73b" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because you have set explicit rev
in Cargo.toml
file. Instead you could just set up github repo and let Cargo.lock
maintain the revision.
But it's fine, might be a bit more pain in the ass to update though:
1. edit Cargo.toml
2. Run $ cargo update -p parity-ui-dev
vs
$ cargo update -p parity-ui-dev
Updating will have to be done manually, i.e. like we do for other packages anyway. We can still push from the Travis build for the shell & wallet to update the refs, but since we want to not have Parity (1.10) build the UI in, I would rather just update manually when we need to since it is not long-term. (But if need be, can just push from CI again) |
I have no idea why 'js' report is |
So long and thanks for all the fish.
cargo update -p parity-ui
cargo build --release --no-default-features --features ui
js-build
&js-release
cc @amaurymartiny @ngotchac @tomusdrw