Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix build #7807

Merged
merged 2 commits into from
Feb 5, 2018
Merged

Fix build #7807

merged 2 commits into from
Feb 5, 2018

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Feb 5, 2018

No description provided.

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Feb 5, 2018
@5chdn 5chdn added this to the 1.10 milestone Feb 5, 2018
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 5, 2018
Copy link
Collaborator

@debris debris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm not sure about this change. All other modules on master are using ethereum-types 0.1. How is the build broken? I can't see it on gitlab

@debris debris added A0-pleasereview 🤓 Pull request needs code review. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Feb 5, 2018
@NikVolf
Copy link
Contributor Author

NikVolf commented Feb 5, 2018

it's broken, because Cargo.lock is also not up-to-date

if you checkout master and do ./test.sh, it will rebuild Cargo.lock and fail to compile after

see this for example: https://gitlab.parity.io/parity/parity/-/jobs/78265

@debris
Copy link
Collaborator

debris commented Feb 5, 2018

ahh, you are right! I thought you changed 0.1 -> 0.2, but it is 0.2 -> 0.1

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 5, 2018
@svyatonik svyatonik merged commit 8587df1 into master Feb 5, 2018
@svyatonik svyatonik deleted the fix-build branch February 5, 2018 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants