This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Store updater metadata in a single place #7832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
andresilva
approved these changes
Feb 8, 2018
| track = "nightly" | ||
|
|
||
| # Latest supported fork blocks for various networks. Used ONLY by auto-updater. | ||
| [package.metadata.forks] |
There was a problem hiding this comment.
Where are these values used?
There was a problem hiding this comment.
I guess nowhere in parity... Used ONLY by auto-updater so https://github.com/paritytech/push-release . am I right @tomusdrw ?
debris
approved these changes
Feb 8, 2018
debris
added
A8-looksgood 🦄
Merged
tomusdrw
added a commit
that referenced
this pull request
Feb 14, 2018
This was referenced Feb 14, 2018
5chdn
pushed a commit
that referenced
this pull request
Feb 14, 2018
* update back-references more aggressively after answering from cache (#7578) * Flush keyfiles. Resolves #7632 (#7868) * Fix wallet import (#7873) * rpc: generate new account id for imported wallets * ethstore: handle duplicate wallet filenames * ethstore: simplify deduplication of wallet file names * ethstore: do not dedup wallet filenames on update * ethstore: fix minor grumbles * parity-version pr reopen (#7136) * parity-version module split from util removed unused util deps and features trigger buildbot again only kvdb links rocksdb snappy linker issues * rm snappy * fixed old version imports * Move updater metadata to Cargo.toml of parity-version. (#7832) * Update version. * Bump parity version. * Fix version. * Fix compilation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all version related stuff to
util/version/Cargo.toml.Updater service will be able to read the toml file and extract all required info.
Grouping the data together will also increase the chance that the stuff is actually modified. We had
FORK_SUPPORTED_KOVAN: u64 = 0since probably no one realised where it is and that it's required to update that.Bonus: removes completely unused
SemanticVersionstuff.