This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix build ```version``` after #7723
debris
approved these changes
Feb 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how 7723 is related, but it works now :)
@debris before the script looked for the version by other rules |
I believe you meant #7832 . Actually that pr is tagged as |
yes, just figured we need this on beta now |
5chdn
pushed a commit
that referenced
this pull request
Feb 14, 2018
fix build ```version``` after #7723
5chdn
pushed a commit
that referenced
this pull request
Feb 14, 2018
fix build ```version``` after #7723
5chdn
added a commit
that referenced
this pull request
Feb 14, 2018
* Resolve conflicts * Resolve conflicts * Update gitlab-build.sh (#7855) fix build ```version``` after #7723 * Resolve conflicts * Update gitlab-test.sh (#7883) * Update gitlab-test.sh #7871 * Update aura-test.sh * Backport master ci prs * Restore js-build * Bump stable to 1.8.10 * Bump stable to 1.8.10 * Make track stable
5chdn
added a commit
that referenced
this pull request
Feb 14, 2018
* Resolve conflicts * Resolve conflicts * Update gitlab-build.sh (#7855) fix build ```version``` after #7723 * Resolve conflicts * Update gitlab-test.sh (#7883) * Update gitlab-test.sh #7871 * Update aura-test.sh * Backport master ci prs * Bump beta to 1.9.3 * Make track beta * Downgrade rustc_version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix build
version
after #7723