Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix installer binary names for macos and windows #7881

Merged
merged 2 commits into from
Feb 13, 2018
Merged

Fix installer binary names for macos and windows #7881

merged 2 commits into from
Feb 13, 2018

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Feb 13, 2018

windows was _ _installer.exe

macos was _macos_macos.pkg

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M1-ci 🙉 Continuous integration. labels Feb 13, 2018
@5chdn 5chdn added this to the 1.10 milestone Feb 13, 2018
maciejhirsz
maciejhirsz approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@maciejhirsz maciejhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejhirsz maciejhirsz added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 13, 2018
@5chdn 5chdn merged commit 3cae42b into master Feb 13, 2018
@5chdn 5chdn deleted the a5-ci-installernames branch February 13, 2018 15:20
@5chdn 5chdn added the B0-patch label Feb 13, 2018
This was referenced Feb 14, 2018
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maciejhirsz maciejhirsz maciejhirsz approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M1-ci 🙉 Continuous integration.
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@5chdn @maciejhirsz