This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix a division by zero in light client RPC handler #7917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @tomaka signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
tomaka
added
F2-bug 🐞
debris
approved these changes
Feb 16, 2018
debris
added
A8-looksgood 🦄
tomusdrw
reviewed
Feb 16, 2018
| @@ -366,7 +367,7 @@ impl OnDemand { | |||
| .filter_map(|pending| { | |||
| // the peer we dispatch to is chosen randomly | |||
| let num_peers = peers.len(); | |||
| let rng = rand::random::<usize>() % num_peers; | |||
| let rng = rand::random::<usize>() % cmp::max(num_peers, 1); | |||
There was a problem hiding this comment.
Maybe it should be a question to the previous PR, but why are we always skipping the same peers from the front of peers?
Wouldn't it be better to randomly partition the collection instead?
There was a problem hiding this comment.
I'm not sure I get it.
The code only chooses one node to dispatch the request to (not a range of nodes). And since we go through the list of nodes twice, each node has an equal chance to be chosen if I'm not mistaken.
There was a problem hiding this comment.
I see, misread the code below. Looks good.
5chdn
added
P2-asap 🌊
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally introduced in #7844