Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

triehash optimisations #7920

Merged
merged 1 commit into from
Feb 16, 2018
Merged

triehash optimisations #7920

merged 1 commit into from
Feb 16, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Feb 16, 2018

significantly reduce number of heap allocations during block verification

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Feb 16, 2018
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, any benchmarks?

@debris
Copy link
Collaborator Author

debris commented Feb 16, 2018

it's Friday evening, will do it tomorrow 😄

Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@5chdn 5chdn added this to the 1.10 milestone Feb 16, 2018
@5chdn 5chdn merged commit f905a16 into master Feb 16, 2018
@5chdn 5chdn deleted the optimise_triehash branch February 16, 2018 19:24
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants