Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

bring back trie and triehash benches #7926

Merged
merged 1 commit into from
Feb 19, 2018
Merged

bring back trie and triehash benches #7926

merged 1 commit into from
Feb 19, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Feb 17, 2018

No description provided.

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Feb 17, 2018
@5chdn 5chdn added this to the 1.10 milestone Feb 17, 2018
@debris debris mentioned this pull request Feb 18, 2018
Closed
tomusdrw
tomusdrw approved these changes Feb 19, 2018
View reviewed changes
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to get results before and after the optimizations you did?

@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 19, 2018
@debris
Copy link
Collaborator Author

debris commented Feb 19, 2018

the difference is not visible in benches, cause all allocations were happening outside of triehash module

@debris debris merged commit 605f3b0 into master Feb 19, 2018
@debris debris deleted the trie_benches branch February 19, 2018 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @tomusdrw @5chdn