This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
kvdb-rocksdb: remove buffered operations when committing transaction #7950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
commented
Feb 19, 2018
| @@ -491,6 +491,9 @@ impl Database { | |||
| let batch = WriteBatch::new(); | |||
| let ops = tr.ops; | |||
| for op in ops { | |||
| // remove any buffered operation for this key | |||
| self.overlay.write()[Self::to_overlay_column(op.col())].remove(op.key()); | |||
There was a problem hiding this comment.
Not sure if I should take a read lock first to check if there's any entry, instead of always locking for write.
There was a problem hiding this comment.
No sure either; is there any reliable way to just benchmark this?
There was a problem hiding this comment.
I believe, we always lock for write
kirushik
approved these changes
Feb 20, 2018
| @@ -491,6 +491,9 @@ impl Database { | |||
| let batch = WriteBatch::new(); | |||
| let ops = tr.ops; | |||
| for op in ops { | |||
| // remove any buffered operation for this key | |||
| self.overlay.write()[Self::to_overlay_column(op.col())].remove(op.key()); | |||
There was a problem hiding this comment.
No sure either; is there any reliable way to just benchmark this?
debris
approved these changes
Feb 20, 2018
debris
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When committing a transaction any keys associated with the transaction are dropped from the overlay.
The test shows the expected semantics for buffered operations.