Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

simplify compression and move it out of rlp crate #7957

Merged
merged 3 commits into from
Feb 23, 2018
Merged

simplify compression and move it out of rlp crate #7957

merged 3 commits into from
Feb 23, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Feb 20, 2018

replaces #7942

changes:

  • removed DBTransaction::put_compressed and all associated types
  • cleaned up rlp compression module
  • moved it to a separate crate - rlp_compression
  • removed deep_decompress functionality, cause there was no deep_compress
  • unified block compression in blockchain module

possible improvements:

  • move rlp_compress/common to ethcore so the crate is not spoiled with ethereum specific compressions

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Feb 20, 2018
@5chdn 5chdn added this to the 1.10 milestone Feb 21, 2018
andresilva
andresilva approved these changes Feb 22, 2018
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

andresilva
andresilva reviewed Feb 22, 2018
View reviewed changes
Cargo.toml
@@ -131,4 +131,5 @@ members = [
"miner",
"transaction-pool",
"whisper",
"util/rlp_compress"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, that's leftover from before this crate was used by ethcore ;)

@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 23, 2018
@5chdn 5chdn merged commit 73756ce into master Feb 23, 2018
@5chdn 5chdn deleted the unify_blocks_compression branch February 23, 2018 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @andresilva @5chdn