Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

make patricia-trie more idiomatic and remove redundant code #8056

Merged
merged 1 commit into from
Mar 6, 2018
Merged

make patricia-trie more idiomatic and remove redundant code #8056

merged 1 commit into from
Mar 6, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 5, 2018

trie iteration benchmarks run 5-10% faster

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Mar 5, 2018
@5chdn 5chdn added this to the 1.11 milestone Mar 5, 2018
andresilva
andresilva approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏎

@andresilva andresilva added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 6, 2018
@andresilva andresilva merged commit ff722ca into master Mar 6, 2018
@debris debris deleted the patricia_trie_idiomatic_changes branch March 6, 2018 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.11 Prosperity
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @andresilva @5chdn