Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

update serde, serde-derive, ethabi-derive, syn, quote and rlp_derive #8085

Merged
merged 1 commit into from
Mar 13, 2018
Merged

update serde, serde-derive, ethabi-derive, syn, quote and rlp_derive #8085

merged 1 commit into from
Mar 13, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 12, 2018

No description provided.

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 12, 2018
@NikVolf
Copy link
Contributor

NikVolf commented Mar 12, 2018

Do we have fuzzing tests for rlp on the CI?

@debris
Copy link
Collaborator Author

debris commented Mar 12, 2018

no and we don't have them in our codebase

folsen
folsen approved these changes Mar 13, 2018
View reviewed changes
Copy link
Contributor

@folsen folsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the code and the updated library docs, LGTM.

+1 for adding fuzz tests for RLP in general, but that would be a separate PR.

@debris debris merged commit c2bd1a0 into master Mar 13, 2018
@debris debris deleted the update_syn branch March 13, 2018 11:43
@5chdn 5chdn added this to the 1.11 milestone Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@folsen folsen folsen approved these changes

Assignees
No one assigned
Labels
A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.11 Prosperity
Development

Successfully merging this pull request may close these issues.
4 participants
@debris @NikVolf @folsen @5chdn