This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Change name Wallet -> UI #8164
Merged
Change name Wallet -> UI #8164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
added
A0-pleasereview 🤓
tomusdrw
approved these changes
Mar 20, 2018
parity/run.rs
Outdated
| @@ -893,8 +893,8 @@ pub fn execute_impl(cmd: RunCmd, can_restart: bool, logger: Arc<RotatingLogger>) | |||
|
|
|||
| pub fn execute(cmd: RunCmd, can_restart: bool, logger: Arc<RotatingLogger>) -> Result<(bool, Option<String>), String> { | |||
| if cmd.ui_conf.enabled { | |||
| warn!("Parity browser interface is deprecated. It's going to be removed in the next version, use standalone Parity Wallet instead."); | |||
| warn!("Standalone Parity Wallet: https://github.com/Parity-JS/shell/releases"); | |||
| warn!("Parity browser interface is deprecated. It's going to be removed in the next version, use standalone Parity UI instead."); | |||
There was a problem hiding this comment.
Looks good, but noticed that it's barely visible, so maybe we could make it bold?
|
I remember trying very hard last year to do exactly the opposite. UI was our internal reference for a product initially called "wallet". I would advise against communicating "UI" externally unless you really insist on this terminology for the broader audience. Also, references would have to be updated everywhere in the documentation. https://wiki.parity.io/Parity-Wallet |
amaury1093
force-pushed
the
am-parity-ui
branch
from
2a61c51
to
cf6e167
Compare
|
The "Wallet" is now just a dapp. We don't have a "Wallet"-only anymore, we have a "dapp browser". (This all changed in 1.9) |
tomusdrw
added
A8-looksgood 🦄
amaury1093
added a commit
that referenced
this pull request
Mar 23, 2018
* Change name Wallet -> UI * Make warning bold
amaury1093
added a commit
that referenced
this pull request
Apr 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussing, Parity UI seemed to be the most popular name for standalone ui app (instead of Parity Wallet).
To be backported to 1.10