This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Re-enable signer, even with no UI. #8167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A3-inprogress ⏳
amaury1093
approved these changes
Mar 20, 2018
andresilva
approved these changes
Mar 20, 2018
| let logger_config_color = logger_config.color; | ||
| let signer_enabled = ui_conf.enabled; | ||
| let signer_path = ws_conf.signer_path.clone(); | ||
| let signer_enabled = ws_conf.support_token_api; | ||
|
|
||
| rpc_apis::SignerService::new(move || { | ||
| generate_new_token(&signer_path, logger_config_color).map_err(|e| format!("{:?}", e)) |
There was a problem hiding this comment.
Can we update the message that's printed by this if the UI is not running?
andresilva
added
A8-looksgood 🦄
andresilva
pushed a commit
that referenced
this pull request
Mar 20, 2018
* Re-enable signer, even with no UI. * Fix message.
Merged
tomusdrw
pushed a commit
that referenced
this pull request
Mar 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to get into
beta.