Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Enable UI by default, but only display deprecation notice #8262

Merged
merged 6 commits into from
Apr 10, 2018
Merged

Conversation

tomusdrw
Copy link
Collaborator

Looks a bit shit, would be good to present some more info there. Feel free to edit the HTML file.

screenshot from 2018-03-29 14-30-18

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. B0-patch M4-core ⛓ Core client code / Rust. labels Mar 29, 2018
@Tbaut
Copy link
Contributor

Tbaut commented Mar 29, 2018

Thanks a lot @tomusdrw
Does this page get shown only for 127.0.0.1:8180/#/v1 or also for 127.0.0.1:8180/ ?
I would also generally talk about the "Browser-based User Interface" rather than "Parity Wallet".
I'd make the change depending on everyone's feedback.

edit: I saw some mention of "parity ui deprecation" in the code, this could be misleading I guess

@5chdn 5chdn added this to the 1.11 milestone Apr 3, 2018
<meta name="viewport" content="width=device-width">
<title>Parity</title>
<style>
/* Copyright 2015-2017 Parity Technologies (UK) Ltd.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018 🤣

@5chdn 5chdn added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. and removed A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Apr 9, 2018
@tomaka tomaka mentioned this pull request Apr 9, 2018
@@ -107,7 +107,7 @@
<div class="parity-navbar">
</div>
<div class="parity-box">
<h1>Parity Wallet is deprecated.</h1>
<h1>Parity browser UI is deprecated.</h1>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the product name is actually Parity Wallet, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving in circles here 🤣

#8164 (comment)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, afaiu we are moving away from "Parity Wallet" (browser wallet) in favour of standalone "Parity UI" (electron app).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being factual here, Parity Wallet is a Dapp, and it's not deprecated:
image

The browser UI is.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, Parity will not support any dapps, UI, wallets whatsoever. The distinction between "Parity Wallet" being a dapp was not really communicated I don't recall changing the names when UI2 has been rolled out. That said I'm not really requesting a change here, just discussing if that's a correct "story" we are telling here.

Anyway, looks good to me 👍 :)

@tomusdrw tomusdrw mentioned this pull request Apr 10, 2018
@folsen
Copy link
Contributor

folsen commented Apr 10, 2018

@tomusdrw @5chdn @Tbaut this text is much clearer IMO, see my commit

@5chdn
Copy link
Contributor

5chdn commented Apr 10, 2018

Thanks.

@5chdn 5chdn merged commit 8348147 into master Apr 10, 2018
@5chdn 5chdn deleted the td-uiinfo branch April 10, 2018 14:14
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants